CSTACKEX-191: logical access methods can have return type as primitive#60
Open
rajiv-jain-netapp wants to merge 1 commit into
Open
CSTACKEX-191: logical access methods can have return type as primitive#60rajiv-jain-netapp wants to merge 1 commit into
rajiv-jain-netapp wants to merge 1 commit into
Conversation
rajiv-jain-netapp
requested review from
piyush5netapp,
sandeeplocharla and
suryag1201
as code owners
suryag1201
reviewed
May 25, 2026
| response = Map.of( | ||
| OntapStorageConstants.LOGICAL_UNIT_NUMBER, lunMapResponse.getRecords().get(0).getLogicalUnitNumber().toString() | ||
| ); | ||
| lunNumber = lunMapResponse.getRecords().get(0).getLogicalUnitNumber().toString(); |
There was a problem hiding this comment.
Null is required here for lunResponse
suryag1201
reviewed
May 25, 2026
suryag1201
left a comment
suryag1201
left a comment
There was a problem hiding this comment.
Please update the testing section after making these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?